projects
/
gtk4.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
91b1476
)
gtkicontheme: Check a return value
author
Matthias Clasen
<mclasen@redhat.com>
Fri, 17 Jul 2015 19:54:40 +0000
(15:54 -0400)
committer
Matthias Clasen
<mclasen@redhat.com>
Fri, 17 Jul 2015 20:11:16 +0000
(16:11 -0400)
We were already looking at the error anyway, but rewriting things
this way lets coverity see the light.
gtk/gtkicontheme.c
patch
|
blob
|
history
diff --git
a/gtk/gtkicontheme.c
b/gtk/gtkicontheme.c
index eebe954798358585277a4f8205e055641399ce17..001dc22b8d0649c28c1fd0ed94dfb35aa18470ed 100644
(file)
--- a/
gtk/gtkicontheme.c
+++ b/
gtk/gtkicontheme.c
@@
-1158,8
+1158,7
@@
insert_theme (GtkIconTheme *icon_theme,
{
theme_file = g_key_file_new ();
g_key_file_set_list_separator (theme_file, ',');
- g_key_file_load_from_file (theme_file, path, 0, &error);
- if (error)
+ if (!g_key_file_load_from_file (theme_file, path, 0, &error))
{
g_key_file_free (theme_file);
theme_file = NULL;
@@
-4098,7
+4097,7
@@
load_icon_thread (GTask *task,
{
GtkIconInfo *dup = task_data;
- icon_info_ensure_scale_and_pixbuf (dup);
+
(void)
icon_info_ensure_scale_and_pixbuf (dup);
g_task_return_pointer (task, NULL, NULL);
}